ACP #12
Merged
ACP #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using this on https://pivot.pondersource.com now |
bourgeoa
approved these changes
Jan 23, 2025
|
Actually this is still the wrong way to use ACP, I should add an |
|
We should change mashlib-on-the-pod to register itself with a static client doc, and then we can whitelist that too. But this might be harder than doing this for a stand-alone version of mashlib. |
FIXME: it seems from https://github.com/CommunitySolidServer/CommunitySolidServer/blob/main/documentation/markdown/usage/seeding-pods.md that in `--seedConfig` you can add custom template variables when seeding a pod, but in https://github.com/CommunitySolidServer/CommunitySolidServer/blob/7baa9e68ab83ef10bc565afb577b5a502003d670/test/unit/identity/interaction/pod/util/BasePodCreator.test.ts#L56-L58 it seems that the only template variables that exist for allowing end-users to create pods are `base.path`, `webId` and `oidcIssuer`. So AFAICS the only way to specify a default clientId here is to hard-code it in this file here.
michielbdejong
commented
Jan 28, 2025
|
@bourgeoa I don't have a merge button here, do you want to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pod template for when Pivot is used in ACP mode